Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Dec 12, 2025

Resolves #19378

Summary by CodeRabbit

  • New Features

    • Chargebee source renamed to "New Event (Instant)" and now supports instant event processing.
    • Added an informational alert guiding setup and webhook configuration.
  • Chores

    • Bumped Chargebee component version.
    • Removed license field from package metadata.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Dec 15, 2025 3:51pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Walkthrough

Bumps package and source versions, renames the Chargebee source display name, adds an info alert and a hooks property, and introduces a processEvent(event) method that emits incoming events with generated metadata.

Changes

Cohort / File(s) Summary
Package metadata
components/chargebee/package.json
Version bumped from 0.1.00.1.1; license field removed.
Event source implementation
components/chargebee/sources/new-event/new-event.mjs
Display name changed to "New Event (Instant)"; version bumped 0.0.20.0.3; added info alert property and hooks: {}; added processEvent(event) method which emits the event using generateMeta(event); existing getEventTypes() and generateMeta() preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review focus:
    • processEvent(event) implementation and correct use of generateMeta(event) for emitted metadata.
    • New info alert content and hooks shape for API/consumption expectations.
    • Version and display-name consistency with documentation or consumer expectations.

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains 'Resolves #19378' but the template requires a 'WHY' section explaining the rationale for changes; the description is largely incomplete. Add a 'WHY' section to explain the rationale behind the changes made in this pull request.
Linked Issues check ⚠️ Warning The PR addresses issue #19378 by emitting full webhook response via the new processEvent method, but does not expose the event type received, include the occurred_at field, or surface the trigger URL in UI. Ensure the processEvent method exposes event type, include occurred_at field in emitted data, and add UI display for the trigger URL.
Out of Scope Changes check ⚠️ Warning The changes include version bump, license removal, and display name update to '(Instant)' which are tangential to the core objective of exposing event data and webhook functionality. Clarify whether version bump and license removal are necessary for this fix or separate from the core functionality improvements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions 'emit full webhook response' which aligns with the main change of adding processEvent method, but does not mention the display name change to '(Instant)' or other version/metadata updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-19378

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

jcortes
jcortes previously approved these changes Dec 12, 2025
Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927 lgtm! Ready for QA!

@vunguyenhung
Copy link
Collaborator

@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check test reports below for more information:

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1440aca and cc043d6.

📒 Files selected for processing (1)
  • components/chargebee/sources/new-event/new-event.mjs (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-01-23T03:55:15.166Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.

Applied to files:

  • components/chargebee/sources/new-event/new-event.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: pnpm publish
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Lint Code Base
🔇 Additional comments (1)
components/chargebee/sources/new-event/new-event.mjs (1)

8-11: Display name and version bump are appropriate

Renaming to "New Event (Instant)" and bumping the version to "0.0.3" aligns with other webhook-style triggers and ensures the change is deployed without affecting the key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRIGGER] Chargebee new event trigger is bereft of useful functionality

4 participants