WIP: Add ability to customize worker prefix #157
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 79.34% 79.06% -0.29%
==========================================
Files 10 10
Lines 1951 1958 +7
==========================================
Hits 1548 1548
- Misses 403 410 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The worker_output_hook API documents that ident is passed as AbstractString, but the connect function in managers.jl was passing the pid as an Int. This caused hooks that expected strings (e.g., using tryparse(Int, ident)) to fail silently. Match the behavior in cluster.jl which already passes "$pid".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For JuliaLang/julia#60372