Refine reactive_file_collection representation

Simplify the reactive_file_collection implementation by making 'v t
be the concrete record type used at runtime, removing the unused
phantom fields and internal wrapper type. This eliminates warning 69
about unused record fields and relies directly on a single record with
its process function stored as an Obj.t-based callback.

Author: cristianoc

analysis/vendor/skip-lite/reactive_file_collection/reactive_file_collection.ml

@@ -5,43 +5,32 @@ type event =
   | Removed of string
   | Modified of string
 
-type 'v t = {
-  data : (string, 'v) Hashtbl.t;
-  process : 'a. 'a -> 'v;
-}
-
-(* We need to use Obj.magic to make the polymorphic process function work
-   with Marshal_cache which returns 'a. This is safe because the user
+(* We need to use Obj.t to make the polymorphic process function work
+   with Marshal_cache which returns ['a]. This is safe because the user
    guarantees the file contains data of the expected type. *)
 type 'v process_fn = Obj.t -> 'v
 
-type 'v t_internal = {
-  data_internal : (string, 'v) Hashtbl.t;
-  process_internal : 'v process_fn;
+type 'v t = {
+  data : (string, 'v) Hashtbl.t;
+  process : 'v process_fn;
 }
 
 let create (type a v) ~(process : a -> v) : v t =
-  let process_internal : v process_fn = fun obj -> process (Obj.obj obj) in
-  let t = {
-    data_internal = Hashtbl.create 256;
-    process_internal;
-  } in
-  (* Safe cast - same representation *)
-  Obj.magic t
-
-let to_internal (t : 'v t) : 'v t_internal = Obj.magic t
+  let process_fn : v process_fn = fun obj -> process (Obj.obj obj) in
+  {
+    data = Hashtbl.create 256;
+    process = process_fn;
+  }
 
 let add t path =
-  let t = to_internal t in
   let value = Marshal_cache.with_unmarshalled_file path (fun data ->
-    t.process_internal (Obj.repr data)
+    t.process (Obj.repr data)
   ) in
-  Hashtbl.replace t.data_internal path value
+  Hashtbl.replace t.data path value
   [@@alert "-unsafe"]
 
 let remove t path =
-  let t = to_internal t in
-  Hashtbl.remove t.data_internal path
+  Hashtbl.remove t.data path
 
 let update t path =
   (* Just reload - Marshal_cache handles the file reading efficiently *)
@@ -53,33 +42,26 @@ let apply t events =
     | Removed path -> remove t path
     | Modified path -> update t path
   ) events
-
 let get t path =
-  let t = to_internal t in
-  Hashtbl.find_opt t.data_internal path
+  Hashtbl.find_opt t.data path
 
 let find t path =
-  let t = to_internal t in
-  Hashtbl.find t.data_internal path
+  Hashtbl.find t.data path
 
 let mem t path =
-  let t = to_internal t in
-  Hashtbl.mem t.data_internal path
+  Hashtbl.mem t.data path
 
 let length t =
-  let t = to_internal t in
-  Hashtbl.length t.data_internal
+  Hashtbl.length t.data
 
 let is_empty t =
   length t = 0
 
 let iter f t =
-  let t = to_internal t in
-  Hashtbl.iter f t.data_internal
+  Hashtbl.iter f t.data
 
 let fold f t init =
-  let t = to_internal t in
-  Hashtbl.fold f t.data_internal init
+  Hashtbl.fold f t.data init
 
 let to_list t =
   fold (fun k v acc -> (k, v) :: acc) t []

yarn.lock

@@ -452,6 +452,12 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@rescript/react@workspace:tests/dependencies/rescript-react":
+  version: 0.0.0-use.local
+  resolution: "@rescript/react@workspace:tests/dependencies/rescript-react"
+  languageName: unknown
+  linkType: soft
+
 "@rescript/runtime@workspace:packages/@rescript/runtime":
   version: 0.0.0-use.local
   resolution: "@rescript/runtime@workspace:packages/@rescript/runtime"
@@ -724,12 +730,6 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@tests/rescript-react@workspace:tests/dependencies/rescript-react":
-  version: 0.0.0-use.local
-  resolution: "@tests/rescript-react@workspace:tests/dependencies/rescript-react"
-  languageName: unknown
-  linkType: soft
-
 "@tests/tools@workspace:tests/tools_tests":
   version: 0.0.0-use.local
   resolution: "@tests/tools@workspace:tests/tools_tests"