Skip to content

Commit 81b2fea

Browse files
Copilotpierceboggan
andcommitted
Revert model name override setting - awaiting clarification on Manage Models page
Co-authored-by: pierceboggan <[email protected]>
1 parent 7be40f5 commit 81b2fea

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

src/extension/conversation/vscode-node/languageModelAccess.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { CopilotToken } from '../../../platform/authentication/common/copilotTok
1111
import { IBlockedExtensionService } from '../../../platform/chat/common/blockedExtensionService';
1212
import { ChatFetchResponseType, ChatLocation, getErrorDetailsFromChatFetchError } from '../../../platform/chat/common/commonTypes';
1313
import { getTextPart } from '../../../platform/chat/common/globalStringUtils';
14-
import { ConfigKey, IConfigurationService } from '../../../platform/configuration/common/configurationService';
1514
import { EmbeddingType, getWellKnownEmbeddingTypeInfo, IEmbeddingsComputer } from '../../../platform/embeddings/common/embeddingsComputer';
1615
import { IEndpointProvider } from '../../../platform/endpoint/common/endpointProvider';
1716
import { CustomDataPartMimeTypes } from '../../../platform/endpoint/common/endpointTypes';
@@ -61,7 +60,6 @@ export class LanguageModelAccess extends Disposable implements IExtensionContrib
6160
@IVSCodeExtensionContext private readonly _vsCodeExtensionContext: IVSCodeExtensionContext,
6261
@IAutomodeService private readonly _automodeService: IAutomodeService,
6362
@IExperimentationService private readonly _expService: IExperimentationService,
64-
@IConfigurationService private readonly _configurationService: IConfigurationService,
6563
) {
6664
super();
6765

@@ -131,19 +129,13 @@ export class LanguageModelAccess extends Disposable implements IExtensionContrib
131129
}
132130
const seenFamilies = new Set<string>();
133131

134-
// Get model name overrides from settings (team internal setting)
135-
const modelNameOverrides = this._configurationService.getConfig(ConfigKey.TeamInternal.ModelNameOverrides);
136-
137132
for (const endpoint of chatEndpoints) {
138133
if (seenFamilies.has(endpoint.family) && !endpoint.showInModelPicker) {
139134
continue;
140135
}
141136
seenFamilies.add(endpoint.family);
142137

143-
// Apply model name override if configured, otherwise use the endpoint name
144-
const modelId = endpoint instanceof AutoChatEndpoint ? AutoChatEndpoint.pseudoModelId : endpoint.model;
145-
const displayName = modelNameOverrides[modelId] ?? endpoint.name;
146-
const sanitizedModelName = displayName.replace(/\(Preview\)/g, '').trim();
138+
const sanitizedModelName = endpoint.name.replace(/\(Preview\)/g, '').trim();
147139
let modelDescription: string | undefined;
148140
if (endpoint.degradationReason) {
149141
modelDescription = endpoint.degradationReason;
@@ -189,15 +181,15 @@ export class LanguageModelAccess extends Disposable implements IExtensionContrib
189181
if (endpoint.customModel) {
190182
const customModel = endpoint.customModel;
191183
modelDetail = customModel.owner_name;
192-
modelDescription = `${displayName} is contributed by ${customModel.owner_name} using ${customModel.key_name}`;
184+
modelDescription = `${endpoint.name} is contributed by ${customModel.owner_name} using ${customModel.key_name}`;
193185
modelCategory = { label: vscode.l10n.t("Custom Models"), order: 2 };
194186
}
195187

196188
const session = this._authenticationService.anyGitHubSession;
197189

198190
const model: vscode.LanguageModelChatInformation = {
199-
id: modelId,
200-
name: endpoint instanceof AutoChatEndpoint ? (modelNameOverrides[modelId] ?? 'Auto') : displayName,
191+
id: endpoint instanceof AutoChatEndpoint ? AutoChatEndpoint.pseudoModelId : endpoint.model,
192+
name: endpoint instanceof AutoChatEndpoint ? 'Auto' : endpoint.name,
201193
family: endpoint.family,
202194
tooltip: modelDescription,
203195
detail: modelDetail,

src/platform/configuration/common/configurationService.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -731,11 +731,6 @@ export namespace ConfigKey {
731731
export const InlineEditsDiagnosticsExplorationEnabled = defineTeamInternalSetting<boolean | undefined>('chat.advanced.inlineEdits.inlineEditsDiagnosticsExplorationEnabled', ConfigType.Simple, false);
732732
export const InternalWelcomeHintEnabled = defineTeamInternalSetting<boolean>('chat.advanced.welcomePageHint.enabled', ConfigType.Simple, { defaultValue: false, internalDefaultValue: true, teamDefaultValue: true, owner: 'lramos15', expirationDate: '2025-12-10' });
733733
export const InlineChatUseCodeMapper = defineTeamInternalSetting<boolean>('chat.advanced.inlineChat.useCodeMapper', ConfigType.Simple, false);
734-
/** Allows staff to override model display names in the model picker dropdown.
735-
* This is useful for creating demo videos before official model name announcements.
736-
* The setting is a map from model ID to the desired display name.
737-
*/
738-
export const ModelNameOverrides = defineTeamInternalSetting<Record<string, string>>('chat.advanced.debug.modelNameOverrides', ConfigType.Simple, {});
739734

740735
// Backed by Experiments
741736
export const DebugCollectFetcherTelemetry = defineTeamInternalSetting<boolean>('chat.advanced.debug.collectFetcherTelemetry', ConfigType.ExperimentBased, true);

0 commit comments

Comments
 (0)