-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Open
Labels
Good first issueIndicates a good issue for first-time contributorsIndicates a good issue for first-time contributorsPriority: LowIndicates that an issue or pull request should be resolved behind issues or pull requests labelled `Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `Status: ParkedIndicates that an issues or pull request will be revisited laterIndicates that an issues or pull request will be revisited laterType: FixIndicates a fix to existing codeIndicates a fix to existing code
Description
From a discussion #3156 (comment) it was thought utilizing the clippy lint clippy::as_conversions would introduce additional safety.
It would be good to implement this lint, either via #![warn(clippy::as_conversions)] or passed as a command line argument under test_clippy.py.
To break up this work, we can implement the following lints incrementally:
- Use
clippy::unnecessary_cast#3195 - Use
clippy::cast_lossless#3196 - Use
clippy::cast_possible_truncation#3197 - Use
clippy::cast_possible_wrap#3198 - Use
clippy::cast_precision_loss#3199 - Use
clippy::cast_sign_loss#3200 - Use
clippy::char_lit_as_u8#3201 - Use
clippy::ref_to_mut#3202 - Use
clippy::ptr_as_ptr#3203 - In
Cargo.tomlreplacewithptr_as_ptr = "warn" cast_lossless = "warn" cast_possible_truncation = "warn" cast_possible_wrap = "warn" cast_sign_loss = "warn"and fix warnings.as_conversions = "warn"
Metadata
Metadata
Assignees
Labels
Good first issueIndicates a good issue for first-time contributorsIndicates a good issue for first-time contributorsPriority: LowIndicates that an issue or pull request should be resolved behind issues or pull requests labelled `Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `Status: ParkedIndicates that an issues or pull request will be revisited laterIndicates that an issues or pull request will be revisited laterType: FixIndicates a fix to existing codeIndicates a fix to existing code