added logic to detect custom http client

Author: kai-ion

src/aws-cpp-sdk-core/include/aws/core/http/HttpClient.h

@@ -48,6 +48,11 @@ namespace Aws
              */
             virtual bool SupportsChunkedTransferEncoding() const { return true; }
 
+            /**
+             * Returns true if this is a default AWS SDK HTTP client implementation.
+             */
+            virtual bool IsDefaultAwsHttpClient() const { return false; }
+
             /**
              * Stops all requests in progress and prevents any others from initiating.
              */

src/aws-cpp-sdk-core/include/aws/core/http/crt/CRTHttpClient.h

@@ -52,6 +52,8 @@ namespace Aws
                 Aws::Utils::RateLimits::RateLimiterInterface* readLimiter,
                 Aws::Utils::RateLimits::RateLimiterInterface* writeLimiter) const override;
 
+            bool IsDefaultAwsHttpClient() const override { return true; }
+
         private:
             // Yeah, I know, but someone made MakeRequest() const and didn't think about the fact that
             // making an HTTP request most certainly mutates state. It was me. I'm the person that did that, and

src/aws-cpp-sdk-core/include/aws/core/http/curl/CurlHttpClient.h

@@ -37,6 +37,8 @@ class AWS_CORE_API CurlHttpClient: public HttpClient
         Aws::Utils::RateLimits::RateLimiterInterface* readLimiter = nullptr,
         Aws::Utils::RateLimits::RateLimiterInterface* writeLimiter = nullptr) const override;
 
+    bool IsDefaultAwsHttpClient() const override { return true; }
+
     static void InitGlobalState();
     static void CleanupGlobalState();
 

src/aws-cpp-sdk-core/include/aws/core/http/windows/IXmlHttpRequest2HttpClient.h

@@ -54,6 +54,8 @@ namespace Aws
              */
             virtual bool SupportsChunkedTransferEncoding() const override { return false; }
 
+            bool IsDefaultAwsHttpClient() const override { return true; }
+
         protected:
             /**
              * Override any configuration on request handle.

src/aws-cpp-sdk-core/include/aws/core/http/windows/WinHttpSyncHttpClient.h

@@ -42,6 +42,8 @@ namespace Aws
              */
             const char* GetLogTag() const override { return "WinHttpSyncHttpClient"; }
 
+            bool IsDefaultAwsHttpClient() const override { return true; }
+
         private:
             // WinHttp specific implementations
             void* OpenRequest(const std::shared_ptr<HttpRequest>& request, void* connection, const Aws::StringStream& ss) const override;

src/aws-cpp-sdk-core/include/aws/core/http/windows/WinINetSyncHttpClient.h

@@ -39,6 +39,8 @@ namespace Aws
              * Gets log tag for use in logging in the base class.
              */
             const char* GetLogTag() const override { return "WinInetSyncHttpClient"; }
+
+            bool IsDefaultAwsHttpClient() const override { return true; }
         private:
 
             // WinHttp specific implementations

src/aws-cpp-sdk-core/include/smithy/client/features/ChunkingInterceptor.h

@@ -29,7 +29,7 @@ class AwsChunkedStreamBuf : public std::streambuf {
     AwsChunkedStreamBuf(Aws::Http::HttpRequest* request,
                         const std::shared_ptr<Aws::IOStream>& stream,
                         size_t bufferSize = DataBufferSize)
-        : m_chunkingStream(Aws::MakeShared<Aws::StringStream>("AwsChunkedStream")),
+        : m_chunkingStream(Aws::MakeShared<Aws::StringStream>(ALLOCATION_TAG)),
           m_request(request),
           m_stream(stream),
           m_data(bufferSize)
@@ -191,20 +191,18 @@ class ChunkingInterceptor : public smithy::interceptor::Interceptor {
 
 private:
     bool ShouldApplyChunking(const std::shared_ptr<Aws::Http::HttpRequest>& request) const {
-        if (!request || !request->GetContentBody()) {
+        // Use configuration setting to determine chunking behavior
+        if (m_httpClientChunkedMode != Aws::Client::HttpClientChunkedMode::DEFAULT) {
             return false;
         }
 
-        // Check if request has checksum requirements
-        const auto& hashPair = request->GetRequestHash();
-        bool hasChecksum = hashPair.second != nullptr;
-        
-        if (!hasChecksum) {
+        if (!request || !request->GetContentBody()) {
             return false;
         }
 
-        // Use configuration setting to determine chunking behavior
-        return m_httpClientChunkedMode == Aws::Client::HttpClientChunkedMode::DEFAULT;
+        // Check if request has checksum requirements
+        const auto& hashPair = request->GetRequestHash();
+        return hashPair.second != nullptr;
     }
 
     Aws::Client::HttpClientChunkedMode m_httpClientChunkedMode;

src/aws-cpp-sdk-core/source/client/AWSClient.cpp

@@ -118,6 +118,15 @@ struct RequestInfo
     }
 };
 
+static ClientConfiguration GetChunkingConfig(const ClientConfiguration& config, const std::shared_ptr<HttpClient>& httpClient)
+{
+    ClientConfiguration chunkingConfig(config);
+    if (!httpClient->IsDefaultAwsHttpClient()) {
+        chunkingConfig.httpClientChunkedMode = HttpClientChunkedMode::CLIENT_IMPLEMENTATION;
+    }
+    return chunkingConfig;
+}
+
 AWSClient::AWSClient(const Aws::Client::ClientConfiguration& configuration,
     const std::shared_ptr<Aws::Client::AWSAuthSigner>& signer,
     const std::shared_ptr<AWSErrorMarshaller>& errorMarshaller) :
@@ -140,7 +149,7 @@ AWSClient::AWSClient(const Aws::Client::ClientConfiguration& configuration,
     m_enableClockSkewAdjustment(configuration.enableClockSkewAdjustment),
     m_requestCompressionConfig(configuration.requestCompressionConfig),
     m_userAgentInterceptor{Aws::MakeShared<smithy::client::UserAgentInterceptor>(AWS_CLIENT_LOG_TAG, configuration, m_retryStrategy->GetStrategyName(), m_serviceName)},
-    m_interceptors{Aws::MakeShared<smithy::client::ChecksumInterceptor>(AWS_CLIENT_LOG_TAG), Aws::MakeShared<smithy::client::features::ChunkingInterceptor>(AWS_CLIENT_LOG_TAG, configuration), m_userAgentInterceptor}
+    m_interceptors{Aws::MakeShared<smithy::client::ChecksumInterceptor>(AWS_CLIENT_LOG_TAG), Aws::MakeShared<smithy::client::features::ChunkingInterceptor>(AWS_CLIENT_LOG_TAG, GetChunkingConfig(configuration, m_httpClient)), m_userAgentInterceptor}
 {
 }
 
@@ -166,7 +175,7 @@ AWSClient::AWSClient(const Aws::Client::ClientConfiguration& configuration,
     m_enableClockSkewAdjustment(configuration.enableClockSkewAdjustment),
     m_requestCompressionConfig(configuration.requestCompressionConfig),
     m_userAgentInterceptor{Aws::MakeShared<smithy::client::UserAgentInterceptor>(AWS_CLIENT_LOG_TAG, configuration, m_retryStrategy->GetStrategyName(), m_serviceName)},
-    m_interceptors{Aws::MakeShared<smithy::client::ChecksumInterceptor>(AWS_CLIENT_LOG_TAG, configuration), Aws::MakeShared<smithy::client::features::ChunkingInterceptor>(AWS_CLIENT_LOG_TAG, configuration), m_userAgentInterceptor}
+    m_interceptors{Aws::MakeShared<smithy::client::ChecksumInterceptor>(AWS_CLIENT_LOG_TAG, configuration), Aws::MakeShared<smithy::client::features::ChunkingInterceptor>(AWS_CLIENT_LOG_TAG, GetChunkingConfig(configuration, m_httpClient)), m_userAgentInterceptor}
 {
 }